Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Pubsub goroutine leak #525

Closed
coder/coder
#17088
@spikecurtis

Description

@spikecurtis

Spotted on testing:

goleak: Errors on successful test run: found unexpected goroutines:
[Goroutine 281873 in state chan send, with github.com/coder/coder/v2/coderd/database/pubsub.(*PGPubsub).startListener.func1 on top of the stack:
github.com/coder/coder/v2/coderd/database/pubsub.(*PGPubsub).startListener.func1(0xc0542f7700?, {0x0, 0x0})
	/home/runner/work/coder/coder/coderd/database/pubsub/pubsub.go:549 +0x3f0
github.com/lib/pq.(*Listener).emitEvent(...)
	/home/runner/go/pkg/mod/github.com/coder/[email protected]/notify.go:825
github.com/lib/pq.(*Listener).listenerConnLoop(0xc0542f7700)
	/home/runner/go/pkg/mod/github.com/coder/[email protected]/notify.go:855 +0xd0
github.com/lib/pq.(*Listener).listenerMain(...)
	/home/runner/go/pkg/mod/github.com/coder/[email protected]/notify.go:884
created by github.com/lib/pq.listener in goroutine 274670
	/home/runner/go/pkg/mod/github.com/coder/[email protected]/notify.go:553 +0x1a7
]
FAIL	github.com/coder/coder/v2/cli	75.434s

https://github.com/coder/coder/runs/39360818266

Appears to be a race condition around the errCh if the context is canceled quickly.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions