Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Devcontainers: The execution of @devcontainers/cli should run with normal agent environment #707

Closed
coder/coder
#18508
@mafredri

Description

@mafredri

Right now @devcontainers/cli is executed using the agentexecer package. However, some environment manipulation is done in (*agentssh.Server).CreateCommand. We should replicate this environment when we run devcontainer up/read-configuration/exec or docker.

This is necessary to ensure that we look for commands in the correct paths, or any other special environment variables present that are required for the aforementioned commands to work.

While we're at it, we don't really need the Docker env infoer with the current approach and could remove it in favor of our current use of devcontainer exec. This should help reduce dependencies to CreateCommand.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions