Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

fix url schema for webrdp example #270

Merged
merged 1 commit into from
Jul 17, 2024
Merged

fix url schema for webrdp example #270

merged 1 commit into from
Jul 17, 2024

Conversation

stirby
Copy link
Contributor

@stirby stirby commented Jul 16, 2024

Tested the corrected URL on dogfood.

Was

module "windows_rdp" {
  source      = "registry.coder.com/coder/module/windows-rdp"
  ...
}

Now

module "windows_rdp" {
  source      = "registry.coder.com/modules/windows-rdp/coder"
  ...
}

@stirby stirby requested review from Parkreiner and matifali July 16, 2024 19:31
@stirby

This comment was marked as resolved.

Sign in to view
matifali
matifali approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was an overlook from last review.
Thank you for noting this.

@stirby stirby merged commit f7f9c8b into main Jul 17, 2024
2 checks passed
@matifali matifali mentioned this pull request Jul 25, 2024
Merged
@matifali matifali deleted the webrdp-link branch October 17, 2024 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

@Parkreiner Parkreiner Awaiting requested review from Parkreiner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stirby @matifali