This repository was archived by the owner on May 15, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
feat(jetbrains-gateway): add releases_base_link/download_base_link variables #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the contribution.
Could you also add some instructions in README.md on how one can set up custom jetbrains hosting?
Also, please take a look at failing tests and bump the version using ./scripts/update-version.sh
matifali
reviewed
Oct 29, 2024
jetbrains-gateway/README.md
Outdated
Comment on lines
75
to
90
### Custom base link | ||
|
||
```tf | ||
module "jetbrains_gateway" { | ||
source = "registry.coder.com/modules/jetbrains-gateway/coder" | ||
version = "1.0.21" | ||
agent_id = coder_agent.example.id | ||
agent_name = "example" | ||
folder = "/home/coder/example" | ||
jetbrains_ides = ["GO", "WS"] | ||
releases_base_link = "https://releases.internal.site/" | ||
download_base_link = "https://download.internal.site/" | ||
default = "GO" | ||
} | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. This example is helpful. But can you also add on how one can set up internal serving for JetBrains IDEs? Thanks
matifali
approved these changes
Oct 29, 2024
matifali
approved these changes
Oct 29, 2024
Hi @kerwin612, could you run |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In offline mode, the currently configured offline download address will be overridden by the parameters of jetbrains-gateway(jetbrains-gateway://connect#......&ide_download_link=https://download.jetbrains.com/idea/ideaIU-XXX.tar.gz).