fix(vault-jwt): store vault token for use in vault jwt module #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a6c156e to
f19c0a4
Compare
|
Thanks @moo-im-a-cow, can we bump the module version by one patch version? I can then make a release. |
is that just in the readme file or somewhere else too? i've incremented the module version to 1.0.21 in the readme file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, the vault jwt module generates a vault token, but it doesnt actually store it for future vault commands to use.
even with the module configured, running
vault token lookupfails, because the login command in the module just prints the token but doesnt keep it to be used by future calls to vaultadded
-field=tokento the write command, which makes it print only the token itself to stdout, not the rest of the info about the tokenthen pipe that into
vault login -, which reads from stdin, and does the process of actually storing the token for future use.(compared to the other vault coder modules which both call
vault login, but this one doesnt, but it should.)