fix(jupyterlab): fix path to jupyter-lab if already installed #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `jupyter-lab` binary already exists in $PATH, as found
by `command -v jupyter-lab`, then we skip installing using
`pipx` or `uv`.
By skipping the install path, we leave `${JUPYTERPATH}` unset, which then leads to a broken module unless `jupyter-lab` just so
happens to be installed at `/jupyter-lab`.
Fix this by calculating the full path to the binary, either from the
install locations of `pipx`, `uv` or, in the case that it was
preinstalled, from the preinstalled location.
matifali
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
jupyter-labbinary already exists in $PATH, as found bycommand -v jupyter-lab, then we skip installing usingpipxoruv.By skipping the install path, we leave
${JUPYTERPATH}unset, which then leads to a broken module unlessjupyter-labjust so happens to be installed at/jupyter-lab.Fix this by calculating the full path to the binary, either from the install locations of
pipx,uvor, in the case that it was preinstalled, from the preinstalled location.I did not test this. I would have added a test but the current tests don't run because
they're too slow.