Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(jetbrains-gateway): add arm64 support #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 3, 2025
Merged

feat(jetbrains-gateway): add arm64 support #452

merged 3 commits into from
May 3, 2025

Conversation

diranged
Copy link
Contributor

@diranged diranged commented Apr 28, 2025 •
edited
Loading

Provide support for running Jetbrains Gateway connections to both ARM64 and AMD64 hosts.

@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Apr 28, 2025
@phorcys420 phorcys420 requested review from matifali and phorcys420 May 2, 2025 20:27
@diranged diranged marked this pull request as ready for review May 2, 2025 20:27
matifali
matifali reviewed May 3, 2025
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Can you also bump the version in README.md by 1 minor version?

@matifali matifali requested a review from DevelopmentCats May 3, 2025 04:16
@phorcys420
Copy link
Member

phorcys420 commented May 3, 2025 •
edited
Loading

FYI you can bump via ./update_version.sh.
I have rebased your branch so make sure to git pull to avoid issues :-)

@diranged
Copy link
Contributor Author

diranged commented May 3, 2025

@phorcys420 So I bumped it by a patch version - 1.0.28 -> 1.0.29 only because it didn't seem like any previous PRs had bumped the minor version. Is that what you were looking for?

@phorcys420
Copy link
Member

yes @diranged !
we don't do proper semver for modules at the moment so this is how it's done currently.

phorcys420
phorcys420 approved these changes May 3, 2025
View reviewed changes
Copy link
Member

@phorcys420 phorcys420 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks a lot for your contribution!

@phorcys420 phorcys420 enabled auto-merge (squash) May 3, 2025 22:32
@phorcys420 phorcys420 merged commit c200eb5 into coder:main May 3, 2025
4 checks passed
@matifali
Copy link
Member

matifali commented May 5, 2025

@phorcys420, we do follow semver now. We do not have strict version checking to enforce this, so the maintainers are responsible for ensuring the correct version bump.

This was supposed to be a minor version bump, as I requested in #452 (review)

@phorcys420
Copy link
Member

ah alright my bad thanks for letting me know!

matifali added a commit that referenced this pull request May 7, 2025
@matifali
chore(jetbrains-gateway): bump minor version number
3600449 
This resolves a conflict with an existing tag and also resolves the required minor version bump from  #452
@matifali matifali mentioned this pull request May 7, 2025
Merged
@angrycub angrycub mentioned this pull request Apr 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matifali matifali matifali left review comments

@phorcys420 phorcys420 phorcys420 approved these changes

@DevelopmentCats DevelopmentCats Awaiting requested review from DevelopmentCats

Assignees

@diranged diranged

Labels
community Pull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diranged @phorcys420 @matifali