feat: prevent path expansion using host context #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any references to `~` should return an error
aslilac
approved these changes
Jun 27, 2025
| return cty.StringVal(path), nil | ||
| } | ||
|
|
||
| if path[0] != '~' { |
There was a problem hiding this comment.
Suggested change
| if path[0] != '~' { | |
| if strings.HasPrefix(path, "~") { |
nit but I think this is easier to read, says what it's doing a little more loudly
There was a problem hiding this comment.
I copied this code directly from the homedir package. Just going leave it.
I made an issue to follow up: #159
There was a problem hiding this comment.
could you leave a comment with a permalink to the original source to make that clearer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any references to
~should return an error