Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(coder/modules/goose): update default values for Goose provider and model variables to empty strings #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025

Conversation

DevelopmentCats
Copy link
Contributor

  • Changed default values from null to empty strings for experiment_goose_provider and experiment_goose_model variables in main.tf to ensure compatibility and avoid null interpolation issues.

…empty strings

- Changed default values from null to empty strings for `experiment_goose_provider` and `experiment_goose_model` variables in main.tf to ensure compatibility and avoid null interpolation issues.
@matifali matifali added the version:patch Add to PRs requiring a patch version upgrade label May 16, 2025
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming you tested that this change fixes the issue.
Also can you please bump the patch version?

@DevelopmentCats
Copy link
Contributor Author

DevelopmentCats commented May 16, 2025

Yeah Ill bump the version now and I have tested it in my environment pulling from the branch.

But now i'm getting npm install issues all of a sudden so I'm going to look into that real quick

edit: nvm im a dummy Im guessing we require the node.js module to use this.

@matifali matifali changed the title fix: update default values for Goose provider and model variables to empty strings fix(coder/modules/goose): update default values for Goose provider and model variables to empty strings May 16, 2025
@DevelopmentCats DevelopmentCats merged commit 8da6887 into main May 16, 2025
3 checks passed
@DevelopmentCats DevelopmentCats deleted the cat/goose-interpolation-fix branch May 16, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:patch Add to PRs requiring a patch version upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants