feat: remove node installation from gemini #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- format shell script
matifali
previously approved these changes
Aug 25, 2025
|
@35C4n0r Just checking but have you tested this module with the new changes? |
Hey @DevelopmentCats, yeah it works fine for me. |
35C4n0r
commented
Aug 25, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR removes the automatic Node.js and npm installation from the Gemini module, standardizing the approach across modules by requiring users to ensure these dependencies are pre-installed.
- Replaced automatic Node.js/npm installation with dependency checking that exits with an error if not found
- Updated documentation to clarify Node.js/npm prerequisites
- Fixed test file paths from install.log to agentapi-start.log
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| registry/coder-labs/modules/gemini/scripts/install.sh | Replaced install_node() with check_dependencies() and improved npm global configuration |
| registry/coder-labs/modules/gemini/main.test.ts | Updated test file paths to reference correct log files |
| registry/coder-labs/modules/gemini/README.md | Updated version to 2.0.0 and clarified Node.js/npm prerequisites |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Description
Standardising this across all modules:
Type of Change
Module Information
Path:
registry/coder-labs/modules/geminiNew version:
v2.0.0Breaking change: [x] Yes [ ] No
Testing & Validation
bun test)bun run fmt)Related Issues