feat: amp upgrades for better ux #390
Open
+260
−170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
reviewed
Aug 26, 2025
| @@ -36,54 +36,97 @@ variable "icon" { | |||
| default = "/icon/sourcegraph-amp.svg" | |||
| } | |||
|
|
|||
| variable "folder" { | |||
| variable "workdir" { | |||
There was a problem hiding this comment.
Is there a reason we changed this since folder is used across almost all modules?
There was a problem hiding this comment.
This makes sense, let me know your thoughts
#362 (comment)
DevelopmentCats
approved these changes
Sep 12, 2025
matifali
reviewed
Sep 13, 2025
Comment on lines
-83
to
69
| > For using **Coder Tasks** with Amp CLI, make sure to pass the `AI Prompt` parameter and set `sourcegraph_amp_api_key`. | ||
| > To use tasks with Amp CLI, create a `coder_parameter` named `"AI Prompt"` and pass its value to the amp-cli module's `ai_prompt` variable. The `folder` variable is required for the module to function correctly. | ||
| > For using **Coder Tasks** with Amp CLI, make sure to set `amp_api_key`. | ||
| > This ensures task reporting and status updates work seamlessly. |
There was a problem hiding this comment.
@35C4n0r, can we give an example of how to use it with Coder Tasks? Something the user can copy and drop in their existing template. Please also test with tasks-docker template.
There was a problem hiding this comment.
@matifali it's already provided in the Usage Example section.
Co-authored-by: Atif Ali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Description
Type of Change
Module Information
Path:
registry/coder-labs/modules/sourcegraph-ampNew version:
v2.0.0Breaking change: [x] Yes [ ] No
Testing & Validation
bun test)bun run fmt)Related Issues