-
Notifications
You must be signed in to change notification settings - Fork 59
feat: refactor claude code to use agentapi module #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # registry/coder/modules/claude-code/README.md # registry/coder/modules/claude-code/main.tf # registry/coder/modules/claude-code/scripts/agentapi-start.sh # registry/coder/modules/claude-code/scripts/agentapi-wait-for-start.sh # registry/coder/modules/claude-code/testdata/agentapi-mock.js
Linked the issue, the issue also asks for subdomain, will add that today. |
added subdomain 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Provided we are cool with the shift of standardization in variables for AI Modules this looks good to me. I have tested and it works fine.
@35C4n0r can you resolve the conflicts here? |
# Conflicts: # registry/coder/modules/claude-code/README.md # registry/coder/modules/claude-code/main.test.ts # registry/coder/modules/claude-code/main.tf # registry/coder/modules/claude-code/testdata/agentapi-mock.js
source = "registry.coder.com/coder/claude-code/coder" | ||
version = "3.0.0" | ||
agent_id = coder_agent.example.id | ||
workdir = "/home/coder/project" | ||
} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this example work as both the API key and the Claude Token are not provided?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, either the key or session token is needed since this it runs a task.
Co-authored-by: Atif Ali <[email protected]>
Co-authored-by: Atif Ali <[email protected]>
Closes #302
Description
Type of Change
Module Information
Path:
registry/[namespace]/modules/[module-name]
New version:
v3.0.0
Breaking change: [ ] Yes [ ] No
Testing & Validation
bun test
)bun run fmt
)Related Issues