Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(registry/modules/goose): default subdomain to false #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(registry/modules/goose): default subdomain to false #420

wants to merge 4 commits into from
+39 −17

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Sep 12, 2025 •
edited
Loading

Relates to coder/coder#18779

See also #419

By default, we set subdomain = true. Most folks testing this out don't have a wildcard subdomain setup. This switches to path-based behaviour by default and adds a note to the troubleshooting section.

Testing notes below:

module "goose" {
  count               = data.coder_workspace.me.start_count
  source              = "/home/coder/src/coder/registry/registry/coder/modules/goose/"
  agent_id            = coder_agent.main.id
  folder              = "/home/coder"
  install_goose       = true
  goose_version       = "stable"
  goose_provider      = "anthropic"
  goose_model         = "claude-3-5-sonnet-latest"
}
Screenshot 2025-09-12 at 14 05 15 Screenshot 2025-09-12 at 14 05 05

@johnstcn johnstcn requested a review from Copilot September 12, 2025 12:01
@johnstcn johnstcn self-assigned this Sep 12, 2025
Copilot
Copilot AI reviewed Sep 12, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes the default value of the subdomain variable from true to false in the goose module to provide better out-of-the-box experience for users who don't have wildcard subdomain setup.

  • Changed default subdomain behavior from subdomain-based to path-based routing
  • Added comprehensive test coverage for both subdomain configurations
  • Updated documentation to explain the default behavior and production recommendations

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
registry/coder/modules/goose/main.tf Changed default value of subdomain variable from true to false
registry/coder/modules/goose/main.test.ts Added test structure and coverage for both subdomain true/false scenarios
registry/coder/modules/goose/README.md Added troubleshooting documentation explaining default behavior and production recommendations

@johnstcn johnstcn requested review from matifali and hugodutka and removed request for matifali and hugodutka September 12, 2025 12:18
@johnstcn johnstcn marked this pull request as draft September 12, 2025 12:24
@johnstcn johnstcn marked this pull request as ready for review September 12, 2025 12:53
@johnstcn johnstcn added the version:patch Add to PRs requiring a patch version upgrade label Sep 12, 2025
@github-actions GitHub Actions
Copy link

❌ Version Bump Validation Failed

Bump Type: patch

Module versions need to be updated but haven't been bumped yet.

Required Actions:

  1. Run the version bump script locally: ./.github/scripts/version-bump.sh patch
  2. Commit the changes: git add . && git commit -m "chore: bump module versions (patch)"
  3. Push the changes: git push

Script Output:

🔍 Detecting modified modules...
Found modules:
registry/coder/modules/goose

📦 Processing: coder/goose
Found git tag: release/coder/goose/v2.1.1 (v2.1.1)
Current version: 2.1.1
New version: 2.1.2
Updating version references for coder/goose in registry/coder/modules/goose/README.md

🔧 Running formatter to ensure consistent formatting...

📋 Summary:
Bump Type: patch

Modules Updated:

- coder/goose: v2.1.1 → v2.1.2

READMEs Updated:

- coder/goose

✅ Version bump completed successfully!
📝 README files have been updated with new versions.

Next steps:
1. Review the changes: git diff
2. Commit the changes: git add . && git commit -m 'chore: bump module versions (patch)'
3. Push the changes: git push

Please update the module versions and push the changes to continue.

@johnstcn johnstcn requested a review from matifali September 12, 2025 13:33
@johnstcn johnstcn mentioned this pull request Sep 12, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@matifali matifali matifali approved these changes

@hugodutka hugodutka hugodutka approved these changes

Assignees

@johnstcn johnstcn

Labels
version:patch Add to PRs requiring a patch version upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnstcn @matifali @hugodutka