Add rebuild button and command #123

nhooyr · 2019-05-20T00:26:30Z

Unfortunately the command is not coming up in the command palette, not sure why.

And no key bind yet, doesn't seem to be exposed in code-server.

This should be good enough for release though.

nhooyr · 2019-05-20T00:32:26Z

sail.js

            } else {
                alert("reload failed; please see logs in sail terminal")
            }
            stopReloadUI()
        }
+    }
+
+    window.addEventListener("ide-ready", () => {


This is where the changes are.

nhooyr · 2019-05-20T00:33:11Z

sail.js

+            text: "rebuild",
+            tooltip: "press super+alt+r to rebuild",
+            command: "rebuild-sail-container"
+            // showBeak: true <- what does this do?


@kylecarbs @code-asher

It adds a little arrow above the item. For example if you click the notification bell it will show up.

scsmithr · 2019-05-20T15:05:57Z

sail.js

-    let elements = document.getElementsByClassName(className);
-    for (let e of elements) {
-        e.parentNode.removeChild(e)
+(function() {


Why wrap this all in a function?

The global variables become scoped to the file. This is what Webpack and other module loaders due for the browser to isolate modules.

nhooyr · 2019-05-20T16:06:19Z

@code-asher, any ideas why the command doesn't show up in the command palette?

code-asher · 2019-05-20T16:23:10Z

I don't think adding something to the command registry adds it to the palette. IIRC there is a workbench registry and registering actions on that is what adds them to the palette (as well as letting you define keybindings).

code-asher · 2019-05-20T16:27:05Z

Actually just ran into code that makes it look like you can manually append to the command palette as well:

MenuRegistry.appendMenuItem(MenuId.CommandPalette, {
	command: {
		id,
		title,
		category
	},
	when
});

We expose the menu registry so that might work.

code-asher · 2019-05-20T16:32:12Z

For keybindings there is the keybinding registry we could expose. I'm not sure what the practical difference is between using the workspace registry vs command + keybinding + menu registry combo.

Edit: nvm, looked at the code, the workspace registry just uses the command, keybinding, and menu registries, so no practical difference.

nhooyr · 2019-05-20T17:04:27Z

Edit: nvm, looked at the code, the workspace registry just uses the command, keybinding, and menu registries, so no practical difference.

If it uses the command registry, why doesn't the rebuild command show up?

nhooyr · 2019-05-20T17:25:33Z

I think I want registerCommandAndKeybindingRule on the IKeybindingsRegistry.

nhooyr · 2019-05-20T17:29:55Z

@code-asher coder/code-server#701

ammario · 2019-05-20T17:52:12Z

I get the following when doing sail run from this branch

2019-05-20 12:51:35 ERROR	failed to wait for project to be online: container cdr_sail not running
+ cd /home/user/go/src/go.coder.com/sail
+ code-server --host localhost --port 0 --data-dir /home/user/.config/Code --extensions-dir /home/user/.vscode/extensions --allow-http --no-auth
+ tee /tmp/code-server.log
internal/buffer.js:53
  throw new ERR_OUT_OF_RANGE(type || 'offset',
  ^

RangeError [ERR_OUT_OF_RANGE]: The value of "offset" is out of range. It must be >= 0 and <= 268. Received 270
    at boundsError (internal/buffer.js:53:9)
    at Buffer.readUInt32BE (internal/buffer.js:196:5)
    at Function.fromBuffer (nbin.js:1:3737)
    at Function.fromBuffer (nbin.js:1:3603)
    at Function.fromBuffer (nbin.js:1:3603)
    at Function.fromBuffer (nbin.js:1:3603)
    at Object.<anonymous> (nbin.js:1:2075)
    at r (nbin.js:1:222)
    at nbin.js:1:1021
    at nbin.js:1:1030
2019-05-20 12:51:35 ERROR	build run failed: container cdr_sail not running

nhooyr · 2019-05-20T17:58:03Z

Seems to be a code-server issue @kylecarbs

code-asher · 2019-05-20T18:23:37Z

Edit: nvm, looked at the code, the workspace registry just uses the command, keybinding, and menu registries, so no practical difference.

If it uses the command registry, why doesn't the rebuild command show up?

That only adds it as a command, the menu registry is what adds it to the palette.

nhooyr · 2019-05-20T18:24:22Z

Then what did you mean by

the workspace registry just uses the command, keybinding, and menu registries, so no practical difference.

What is the workspace registry for?

code-asher · 2019-05-20T18:29:25Z

As far as I can tell, when you call registerWorkbenchAction on the workbench registry, it essentially just calls CommandsRegistry.registerCommand (this adds the command), KeybindingsRegistry.registerKeybindingRule (this adds the keybinding to run the command), and MenuRegistry.appendMenuItem (this adds the command to the command palette) (and MenuRegistry.addCommand but I tested without that and it still works so I'm not sure what it does).

So you could call all three manually, or call registerWorkbenchAction and let it do all three.

nhooyr · 2019-05-20T18:30:49Z

Sounds good, I think we need to expose it though.

code-asher · 2019-05-20T18:31:16Z

Yup, and SyncActionDescriptor as well looks like since that's what it takes as an argument.

nhooyr · 2019-05-20T18:31:26Z

What does that do?

code-asher · 2019-05-20T18:32:10Z

My bad, edited my response but the workbench registry takes a SyncActionDescriptor as an argument. It looks basically like a sort of wrapper around a command.

code-asher · 2019-05-20T18:33:01Z

Might not be a bad idea to just expose the service collection in its entirety. I think we discussed doing that at one point.

code-asher · 2019-05-20T18:36:38Z

nvm on my previous comment, I got service collections and the registries mixed up. I don't think the registries exist on the service collection.

nhooyr · 2019-05-20T18:38:34Z

Yea, I'm working on it. Just going to import the global registry and expose it.

nhooyr · 2019-05-20T19:09:36Z

@code-asher PR updated

nhooyr · 2019-05-20T21:46:56Z

Should be good now, key bind is cmd+r and it shows up in command palette so a user can rebind if they want.

nhooyr · 2019-05-20T21:47:39Z

(ctrl+r on linux/windows)

nhooyr · 2019-05-20T22:26:41Z

This PR is just waiting for a new release of code-server to include the actions registry API.

code-asher · 2019-05-20T22:46:50Z

🎉 https://github.com/cdr/code-server/releases/tag/1.1119-vsc1.33.1 🎉

code-asher

LGTM.

code-asher · 2019-05-20T22:54:02Z

sail.js

+        const statusBarService = window.ide.workbench.statusbarService
+        statusBarService.addEntry({
+            text: "rebuild",
+            tooltip: "press super+r to rebuild",


ctrl or cmd now, but since the user can customize keybindings it might be better not to display this text at all. There is probably a way to get the current keybinding but I'm not sure off the top of my head how you'd access that.

code-asher · 2019-05-20T22:54:45Z

sail.js

    })
-})
+}())


Not really any of my business, but I am curious about the loss of the newline.

code-asher · 2019-05-20T22:55:18Z

sail.js

+        }), "sail: Rebuild container", "sail");
+
+        const statusBarService = window.ide.workbench.statusbarService
+        statusBarService.addEntry({


Did we want to only show this when we detect a change to the Dockerfile?

I think we can just leave it there.

Also prevent rebuild while rebuild is in progress, just in case.

Add rebuild button and command

8aa7b57

nhooyr requested review from kylecarbs and ammario May 20, 2019 00:26

nhooyr force-pushed the button branch from 008820d to 5525ad8 Compare May 20, 2019 00:31

nhooyr commented May 20, 2019

View reviewed changes

scsmithr reviewed May 20, 2019

View reviewed changes

Move all javascript into function scope

8f5e2fe

nhooyr force-pushed the button branch from 9056fc0 to 8f5e2fe Compare May 20, 2019 16:05

Use actions registry

45af165

nhooyr requested a review from code-asher May 20, 2019 21:47

code-asher reviewed May 20, 2019

View reviewed changes

Prevent keypresses while reload occurs

10bf740

Also prevent rebuild while rebuild is in progress, just in case.

nhooyr force-pushed the button branch from b28ceeb to 10bf740 Compare May 20, 2019 23:16

nhooyr merged commit 3a40670 into master May 20, 2019

nhooyr deleted the button branch May 20, 2019 23:16

Add rebuild button and command #123

Add rebuild button and command #123

Conversation

nhooyr commented May 20, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nhooyr commented May 20, 2019

code-asher commented May 20, 2019

code-asher commented May 20, 2019 • edited Loading

code-asher commented May 20, 2019 • edited Loading

nhooyr commented May 20, 2019 • edited Loading

nhooyr commented May 20, 2019

nhooyr commented May 20, 2019

ammario commented May 20, 2019

nhooyr commented May 20, 2019

code-asher commented May 20, 2019

nhooyr commented May 20, 2019

code-asher commented May 20, 2019 • edited Loading

nhooyr commented May 20, 2019

code-asher commented May 20, 2019 • edited Loading

nhooyr commented May 20, 2019

code-asher commented May 20, 2019

code-asher commented May 20, 2019

code-asher commented May 20, 2019

nhooyr commented May 20, 2019

nhooyr commented May 20, 2019

nhooyr commented May 20, 2019

nhooyr commented May 20, 2019

nhooyr commented May 20, 2019

code-asher commented May 20, 2019 • edited Loading

code-asher left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

code-asher commented May 20, 2019 •

edited

Loading

code-asher commented May 20, 2019 •

edited

Loading

nhooyr commented May 20, 2019 •

edited

Loading

code-asher commented May 20, 2019 •

edited

Loading

code-asher commented May 20, 2019 •

edited

Loading

code-asher commented May 20, 2019 •

edited

Loading

code-asher left a comment •

edited

Loading