This repository was archived by the owner on Apr 28, 2020. It is now read-only.
Add install script for macOS and linux #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you guys think it's worth making the script POSIX instead of bash? Would make it uglier but work across more platforms. |
scsmithr
reviewed
May 22, 2019
install.sh
Outdated
| log "finding latest release" | ||
| local os=$1 | ||
| download https://api.github.com/repos/cdr/sail/releases/latest | | ||
| jq -r ".assets[] |
There was a problem hiding this comment.
I don't think it's a good idea to assume jq is installed.
There was a problem hiding this comment.
That's a fair point. It just makes it so nice and easy 😭
There was a problem hiding this comment.
Jank shell solution:
curl https://api.github.com/repos/cdr/sail/releases/latest | grep "browser_download_url" | grep "linux" | awk -F": " '{print $2}'
There was a problem hiding this comment.
yeah definitely can't use jq...
ammario
suggested changes
May 22, 2019
install.sh
Outdated
| log "finding latest release" | ||
| local os=$1 | ||
| download https://api.github.com/repos/cdr/sail/releases/latest | | ||
| jq -r ".assets[] |
There was a problem hiding this comment.
yeah definitely can't use jq...
|
Also should amend docs |
|
@nhooyr isn't bash universal these days? |
|
Yea pretty much, I guess its nbd, lets see if anyone wants a POSIX compliant script after release. |
scsmithr
approved these changes
May 22, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #150