Added nodejs and npm for chrome extension #164
Conversation
|
Note: This currently fails. I am working on a fix for this. |
|
Ok, This is ready for review. |
There was a problem hiding this comment.
Thanks for contributing!
I added a few comments to adjust some things. Also, I think this can all be collapsed into one commit message since it's just an addition of node/npm.
We'll add a CONTRIBUTING.md soon to give better guidance on commit messages and how things should be formed.
.sail/Dockerfile
Outdated
| @@ -1,5 +1,6 @@ | |||
| FROM codercom/ubuntu-dev-go:latest | |||
|
|
|||
| RUN sudo apt-get update | |||
There was a problem hiding this comment.
Any apt-get update should be combined with an apt-get install in a single RUN operation.
.sail/Dockerfile
Outdated
|
|
||
| RUN installext peterjausovec.vscode-docker | ||
|
|
||
| RUN sudo apt-get install curl -y |
There was a problem hiding this comment.
curl is already installed in the base image
.sail/Dockerfile
Outdated
|
|
||
| RUN sudo apt-get install curl -y | ||
|
|
||
| RUN sudo apt-get install software-properties-common -y && \ |
There was a problem hiding this comment.
I think we should use nvm for installing node, see instructions here.
@kylecarbs what do you think?
|
I will make some updates and you can squash and merge 😄 |
|
If it is decided to change this to NVM, can we do this in a later PR? |
|
I'd rather just use NVM in this PR and change it later if needed, as I'm pretty sure that's how Kyle will want it installed. Also, that'll remove the need to install |
|
Ok, will update that after I am done submitting this other PR. |
|
@nathanpotter This PR should be good to go. |
Co-Authored-By: Nathan Potter <[email protected]>
Co-Authored-By: Nathan Potter <[email protected]>
|
Good to go |
Co-Authored-By: Nathan Potter <[email protected]>
|
👍 |
This PR is to solve the issue when trying to develop for the chrome extension through sail.
Currently, when running
sail run roberthmiller/sail, I am unable to use npm (getting the deps for the chrome extension). This PR is to fix that.Edit:
Resolves #161