Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: Remove IgnoreErrors check for test logger #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2021
+1 −4
Merged

chore: Remove IgnoreErrors check for test logger #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c1ab03
chore: Remove IgnoreErrors check for test logger
scsmithr Jun 9, 2021
eb61a52
Update test
scsmithr Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions sloggers/slogtest/t.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,6 @@ func (ts testSink) LogEntry(ctx context.Context, ent slog.SinkEntry) {
ts.tb.Error(s)
}
case slog.LevelFatal:
if ts.opts.IgnoreErrors {
panic("slogtest: cannot fatal in tests when IgnoreErrors option is set")
}
ts.tb.Fatal(s)
}
}
Expand Down
2 changes: 1 addition & 1 deletion sloggers/slogtest/t_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func TestIgnoreErrors(t *testing.T) {

defer func() {
recover()
assert.Equal(t, "fatals", 0, tb.fatals)
assert.Equal(t, "fatals", 1, tb.fatals)
}()

l.Fatal(bg, "hello")
Expand Down