Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add support for custom github url #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add support for custom github url #3

wants to merge 1 commit into from

Conversation

renebarak
Copy link

This change is adding support for custom GitHub URL value (e.g., to support Enterprise GitHub URLs). It is backwards compatible with the previous version and uses the same default as before.

matifali
matifali previously approved these changes Jun 25, 2025
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@matifali matifali dismissed their stale review June 25, 2025 16:27

Looks like it's not enough.

@Jphalan
Copy link

Jphalan commented Jun 25, 2025

@matifali a little more context:
-Customer discovered this github action: (https://github.com/coder/start-workspace-action/tree/main).
-It doesn't support github enterprise override, it always invokes github.com (code reference: https://github.com/coder/start-workspace-action/blob/main/action.yml#L47)
-Goal: Expose that as an additional parameter?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matifali matifali matifali left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renebarak @Jphalan @matifali