fix: never use STUN latency for DERP region netcheck #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the STUN probe to still run as usual, but avoid storing the latency in the region report. This was causing Google STUN to artificially make the default region have an extremely low latency. Also fixes HTTPS latency check to work on ForceHTTP nodes.
coadler
approved these changes
Jul 31, 2023
deansheather
added a commit
that referenced
this pull request
Jul 31, 2023
Changes the STUN probe to still run as usual, but avoid storing the latency in the region report. This was causing Google STUN to artificially make the default region have an extremely low latency. Also fixes HTTPS latency check to work on ForceHTTP nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the STUN probe to still run as usual, but avoid storing the latency in the region report. This was causing Google STUN to artificially make the default region have an extremely low latency.
Also fixes HTTPS latency check to work on ForceHTTP nodes.