chore: change DNS record TTL from 10 minutes to 2 seconds #70
+19
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Apr 9, 2025
| // Coder: We've changed this from 10 minutes to 2 seconds, as we'd like to use | ||
| // the existence of Coder Connect DNS records to determine whether Coder Connect | ||
| // is running. | ||
| const defaultTTL = 2 * time.Second |
There was a problem hiding this comment.
10 seconds sounds better to me. The only time that records will conflict will be during a restart of a workspace, which I would guess takes 20-30 seconds in the fastest possible template.
There was a problem hiding this comment.
We aren't just worried about records with conflicting IP addresses, we are worried about turning off Coder Connect entirely and then using some other tool to connect to the workspace, and having the OS return a stale record indicating that Coder Connect is running when it isn't.
So, the relevant time scale is how quickly a human can turn off Coder Connect and then switch to another tool, not a workspace restart.
ethanndickson
added a commit
to coder/coder
that referenced
this pull request
Apr 11, 2025
Relates to coder/internal#466 Brings in coder/tailscale#70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to coder/internal#466
This modifies the TTL of all DNS records programmed into the DNS resolver.
I've tested this by running Coder Desktop macOS against a fresh dylib: