Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Add flag to enable managed variables #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2023
Merged

feat: Add flag to enable managed variables #97

merged 2 commits into from
Feb 10, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Feb 10, 2023 •
edited
Loading

Related: coder/coder#5980

This PR introduces a feature flag to enable managed template-wide variables. The flag is required to select the processing strategy - either use legacy Parameter Schema or new template variables (under development).

Comment:
I had to add this flag as terraform complains:

> Upload "mtojek/docker-rich"? (yes/no) yes
✔ Queued [571ms]
✔ Setting up [1ms]
✔ Parsing template parameters [60ms]
⧗  Detecting persistent resources
  Terraform 1.2.6
  Error: Unsupported argument
  An argument named "feature_use_managed_variables" is not expected here.
✔ Detecting persistent resources [7623ms]
✘ Cleaning Up [110ms]

The idea is to remove the flag as the new strategy will be enabled by default.

@mtojek mtojek self-assigned this Feb 10, 2023
@mtojek mtojek requested review from kylecarbs and mafredri February 10, 2023 09:34
@mtojek mtojek marked this pull request as ready for review February 10, 2023 09:34
mafredri
mafredri approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably shouldn't remove the flag once we make it default, but we can mark it as deprecated.

@mtojek
Copy link
Member Author

mtojek commented Feb 10, 2023

As an alternative option, I was considering a template_format_version, but it might be too wide, and in general feature flags are useful. I don't have strong feelings about it, and I'm happy to change it if somebody has a good idea.

@mtojek mtojek merged commit 951cd3c into coder:main Feb 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtojek @mafredri