fix: create new template version when tfvars change #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
2a47980 to
81449d0
Compare
ethanndickson
commented
Sep 13, 2024
| Name string `json:"name"` | ||
| ID uuid.UUID `json:"id"` | ||
| Name string `json:"name"` | ||
| TFVars map[string]string |
There was a problem hiding this comment.
My understanding from testing is that adding a new field to a struct is backwards compatible (which is also why omitempty works) - if we read some private state from an older version of the provider the map will just be nil.
81449d0 to
b704ee6
Compare
deansheather
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #97.