Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove extraneous polling #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 14, 2024
Merged

Remove extraneous polling #382

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e72e697
Make workspaces fetch private
code-asher Oct 14, 2024
7b280a0
Use web socket for workspace notifications
code-asher Oct 14, 2024
7e79d70
Prevent immediately polling when connecting
code-asher Oct 14, 2024
127e579
Update workspace in commands
code-asher Oct 14, 2024
f497367
Notify when workspace stops running
code-asher Oct 14, 2024
af8a2b3
Tweak update text
code-asher Oct 14, 2024
6a69956
Add owner name to logs and notifications
code-asher Oct 14, 2024
c9aa26d
Add changelog entries
code-asher Oct 14, 2024
699324c
Tweak status bar item name
code-asher Oct 14, 2024
9e578dd
Make reload notification a modal again
code-asher Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tweak update text 
It says the window will reload, but the command has no way of knowing
that is the case.  Maybe the command could automatically reload, but for
now, a second notification will inform the user that the window needs to
be reloaded, and they can choose whether they want to do so.
  • Loading branch information
@code-asher
code-asher committed Oct 14, 2024
commit af8a2b3d2c027d6ab2efecc6aedac6db5284aaee
2 changes: 1 addition & 1 deletion src/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ export class Commands {
{
useCustom: true,
modal: true,
detail: `${this.workspace.owner_name}/${this.workspace.name} will be updated then this window will reload to watch the build logs and reconnect.`,
detail: `Update ${this.workspace.owner_name}/${this.workspace.name} to the latest version?`,
},
"Update",
)
Expand Down