Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix race with c.readerShouldLock #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2019
Merged

Fix race with c.readerShouldLock #169

merged 2 commits into from
Nov 5, 2019

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Nov 4, 2019

Closes #168

@nhooyr
Copy link
Contributor Author

nhooyr commented Nov 4, 2019

Please test @andersfylling

@github-actions
Copy link

github-actions bot commented Nov 4, 2019

Coverage Status

Coverage decreased (-0.3%) to 92.175% when pulling 780bda4 on race into e36318f on master.

@andersfylling
Copy link

Ran the integration tests again; 6 times with the patch, no race detected. 3 times without the patch and a race was detected 2/3 times.

Note that I tested the ddeaed2 commit .

@nhooyr
Copy link
Contributor Author

nhooyr commented Nov 5, 2019

Awesome. The second commit is unrelated to the core problem, just clarifies a confusing error msg.

Will release v1.7.3

@nhooyr nhooyr merged commit f178ccf into master Nov 5, 2019
@nhooyr nhooyr deleted the race branch November 5, 2019 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race condition
2 participants
@nhooyr @andersfylling