Thanks to visit codestin.com
Credit goes to github.com

Skip to content

netconn.go: Prevent timer leakage #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2020
Merged

netconn.go: Prevent timer leakage #255

merged 1 commit into from
Jul 5, 2020

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Jul 4, 2020

Closes #243

@nhooyr
Copy link
Contributor Author

nhooyr commented Jul 4, 2020

Please review @ash2k!

@nhooyr nhooyr changed the title netconn: Prevent timer leakage netconn.go: Prevent timer leakage Jul 4, 2020
@ash2k
Copy link
Contributor

ash2k commented Jul 5, 2020

Looks good to me, thanks.

@nhooyr
Copy link
Contributor Author

nhooyr commented Jul 5, 2020

Awesome thanks for reviewing.

@nhooyr nhooyr merged commit 493ebbe into dev Jul 5, 2020
@nhooyr nhooyr deleted the netconn-timers branch July 5, 2020 21:01
nhooyr added a commit that referenced this pull request Jan 9, 2021
@nhooyr
netconn: Cleanup contexts on close
5f08317 
Updates #255
nhooyr added a commit that referenced this pull request Jan 9, 2021
@nhooyr
netconn.go: Cleanup contexts on close
5070c14 
Updates #255
nhooyr added a commit that referenced this pull request Jan 9, 2021
@nhooyr
netconn.go: Cleanup contexts on close
482f584 
Updates #255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhooyr @ash2k