Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix closenow race #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 7, 2024
Merged

fix closenow race #427

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
46f4112
fix closenow race
alixander Dec 18, 2023
0b3912f
accept_test: Fix @alixander's test
nhooyr Apr 5, 2024
db18a31
close.go: Rewrite how the library handles closing
nhooyr Apr 5, 2024
856e371
ws_js: Update to match new close code
nhooyr Apr 5, 2024
0edbb28
netconn: fmt
nhooyr Apr 5, 2024
c97fb09
mask_asm: Disable for now until v1.9.0
nhooyr Apr 6, 2024
211ef4b
ws_js_test: Fix
nhooyr Apr 7, 2024
250db1e
read: Fix CloseRead to have its own done channel
nhooyr Apr 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
accept_test: Fix @alixander's test 
Not ideal but whatever, I'm going to rewrite all of this anyway.
  • Loading branch information
@nhooyr
nhooyr committed Apr 5, 2024
commit 0b3912f68dc3389749e822b03bbbb8e7a138fd11
4 changes: 1 addition & 3 deletions accept_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ package websocket
import (
"bufio"
"errors"
"io"
"net"
"net/http"
"net/http/httptest"
Expand Down Expand Up @@ -149,8 +148,7 @@ func TestAccept(t *testing.T) {

server, _ := net.Pipe()

pr, pw := io.Pipe()
rw := bufio.NewReadWriter(bufio.NewReader(pr), bufio.NewWriter(pw))
rw := bufio.NewReadWriter(bufio.NewReader(server), bufio.NewWriter(server))
newResponseWriter := func() http.ResponseWriter {
return mockHijacker{
ResponseWriter: httptest.NewRecorder(),
Expand Down