Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Collaborator
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
ammar-agent
force-pushed
the
bugs
branch
7 times, most recently
from
October 10, 2025 02:38
ff96164 to
8c6fcb2
Compare
ammar-agent
force-pushed
the
bugs
branch
4 times, most recently
from
October 10, 2025 15:32
3d7a26d to
ced3dfa
Compare
ammario
approved these changes
Oct 10, 2025
Implements comprehensive git status system with background fetching: Git Status System: - Context-based git status polling (3s intervals) - Smart git fetch with no prompts (prevents keychain spam) - Exponential backoff on fetch failures (3s → 60s max) - Deduplication: one fetch per project per interval - Optimized fetch flags (protocol v2, --filter=blob:none) - All errors logged to console, never shown to user Sidebar Improvements: - Swap workspace status and actions positions ([×] [git] Name [●]) - Right-align workspace names - Fix layout shift when git status is null (render empty placeholder) - Remove duplicate tooltip on remove button Code Organization: - Move backend git code to src/services/gitService.ts - Frontend-safe shared code in src/utils/git/gitStatus.ts - Centralize git status script and parsing logic (DRY) - Debug tool reuses production code paths Performance: - Non-blocking background fetches - Batched git status checks (max 5 concurrent) - No CPU spikes or UI blocking All static checks pass (lint, fmt, typecheck).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminates infinite loops, removes flicker, and reduces IPC overhead by 5x.
Changes
Architecture: Merged
useGitStatusintouseWorkspaceManagementfor single source of truth. Git polling uses refs to break circular dependencies, preventing infinite loops.Performance: Consolidated 5 IPC calls per workspace into 1 bash script. With 10 workspaces polling every second: 50 calls/sec → 10 calls/sec.
UX: Incremental state updates preserve git status during workspace changes, eliminating flicker. 4-column CSS grid prevents layout shifts when git status loads.
Commits
All tests pass. No breaking changes.
Generated with
cmux