🤖 revert: native macOS shortcut label formatting (#4046) - #4075
Merged
Conversation
…)" This reverts commit ffa2780.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This comment has been minimized.
This comment has been minimized.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #4046 (merge commit ffa2780). macOS shortcut labels go back to the previous middle-dot form ("⌘·P", "⌘·⇧·P") and
DirectoryPickerModalregains its hardcoded "⌘O" label. Windows/Linux output was never affected.Background
Requested by Mike. This is a plain
git revertof the squash-merged commit; the only difference from the pre-#4046 tree is the unrelatedSETTINGS_BACKUP_TOGGLE_PROJECTSregistry entry added later by #4043, which auto-merged cleanly.Validation
src/browser/utils/ui/keybinds.test.ts(35 tests) andmake static-checkpass locally.ffa2780f^, andkeybinds.tsdiffers from it only by the 🤖 feat: opt-in project bundle for settings backup #4043 hunk.Risks
Display-only; no keybind matching or registry changes.
Generated with
xum• Model:anthropic:claude-fable-5-1• Thinking:xhigh• Cost:$0.00