Thanks to visit codestin.com
Credit goes to github.com

Skip to content

πŸ€– feat: enable Astra Pro and advisor reasoning mode - #4106

Merged
ThomasK33 merged 2 commits into
mainfrom
model-config-0nmk
Sep 6, 2026
Merged

πŸ€– feat: enable Astra Pro and advisor reasoning mode#4106
ThomasK33 merged 2 commits into
mainfrom
model-config-0nmk

Conversation

@ThomasK33

@ThomasK33 ThomasK33 commented Sep 6, 2026

Copy link
Copy Markdown
Member

Summary

Enable GPT-6-Astra Pro mode and make Pro selectable independently of reasoning effort in Settings β†’ Experiments β†’ Advisor Tool.

Astra was explicitly excluded from the Pro capability check while launch documentation disagreed. Advisor configuration also lacked a saved reasoning mode. This adds Astra to the existing capability gate and reuses the shared route-aware reasoning picker rather than creating another settings control.

  • Keep Standard as the default; choosing Max effort does not implicitly enable Pro.
  • Persist advisor mode independently of effort and the calling chat's mode, including null clearing and malformed-value recovery.
  • Pin advisor provider route and wire options so unsupported gateways, Chat Completions, and Codex routes do not receive Pro.
  • Preserve mapped-model capabilities, display the capability-valid effort actually sent by the advisor (without chat-only minimums), and keep the popup within its row at desktop/tablet/phone widths.

Validation

  • Rebased onto current main; make static-check-full passed with the repository-pinned Bun 1.3.5 after review fixes.
  • 522 targeted unit tests and 3 real config IPC tests passed after the rebase.
  • 3 full-app Storybook interaction tests passed, including the pinned Tablet variant and row-bound popup assertions.
  • Desktop, 744px tablet, and 375px/390px phone dogfood: keyboard Pro toggling, independent effort changes, settings remount persistence, and no horizontal overflow.
  • Final read-only integration review found no issues.

Provider payload serialization is covered with the real OpenAI SDK; no live provider calls were made. Pixel checks are excluded from merge-readiness evaluation at the requester's direction; responsive evidence is included below.

Dogfood evidence

Desktop

Advisor reasoning picker with Astra Pro

Phone

Advisor Pro at 375px

Keyboard and persistence walkthrough

advisor-low-pro-remount.webm

Generated with mux β€’ Model: coder:openai/gpt-6-astra β€’ Thinking: high

Enable GPT-6-Astra Pro on supported Responses routes and reuse the shared reasoning picker for advisor experiment settings. Persist advisor mode independently of effort and parent-chat mode, and pin provider route/wire options for safe request delivery.

Validated with 522 targeted unit tests, 3 config IPC tests, 2 full-app story interactions, make static-check, and desktop/phone keyboard and persistence dogfooding.

---
_Generated with [`mux`](https://github.com/coder/mux) β€’ Model: `coder:openai/gpt-6-astra` β€’ Thinking: `high`_

<!-- mux-attribution: model=coder:openai/gpt-6-astra thinking=high costs=11.03 -->
@chatgpt-codex-connector

This comment has been minimized.

@ThomasK33

Copy link
Copy Markdown
Member Author

@codex review

Review the current head f15e63a5f1f399950f8bb6b0df4907171828f0b4.


Generated with mux β€’ Model: coder:openai/gpt-6-astra β€’ Thinking: high

@ThomasK33

Copy link
Copy Markdown
Member Author

@codex review for security issues

Review the current head f15e63a5f1f399950f8bb6b0df4907171828f0b4.


Generated with mux β€’ Model: coder:openai/gpt-6-astra β€’ Thinking: high

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: f15e63a5f1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

This comment has been minimized.

@chatgpt-codex-connector

This comment has been minimized.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’‘ Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f15e63a5f1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/browser/features/Settings/Sections/AdvisorToolExperimentConfig.tsx Outdated
Comment thread src/common/types/thinking.ts
Preserve capability-only advisor effort without applying chat minimums, reserve the full reasoning menu width, and document Astra Pro availability. Add effort-fidelity and menu-bound regressions plus tablet coverage.

Validated with 388 targeted unit tests, 3 full-app stories, make static-check-full, and desktop/phone/tablet dogfood.

---
_Generated with [`mux`](https://github.com/coder/mux) β€’ Model: `coder:openai/gpt-6-astra` β€’ Thinking: `high`_

<!-- mux-attribution: model=coder:openai/gpt-6-astra thinking=high costs=22.25 -->
@mintlify

mintlify Bot commented Sep 6, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
Mux 🟒 Ready View Preview Sep 6, 2026, 4:38 PM

πŸ’‘ Tip: Enable Automations to automatically generate PRs for you.

@ThomasK33

Copy link
Copy Markdown
Member Author

@codex review

All three prior findings were fixed and replied to in d56e01291b3c5da4e3c7dfbe0965a82195f17d44. Please review this head.


Generated with mux β€’ Model: coder:openai/gpt-6-astra β€’ Thinking: high

@ThomasK33

Copy link
Copy Markdown
Member Author

@codex security review

All three prior findings were fixed and replied to in d56e01291b3c5da4e3c7dfbe0965a82195f17d44. Please review this head.


Generated with mux β€’ Model: coder:openai/gpt-6-astra β€’ Thinking: high

@chatgpt-codex-connector

This comment has been minimized.

@ThomasK33

Copy link
Copy Markdown
Member Author

@codex review

Retrying the failed normal review on d56e01291b3c5da4e3c7dfbe0965a82195f17d44 after the connector reported Unknown error. No implementation changes since the previous request; security review is already running.


Generated with mux β€’ Model: coder:openai/gpt-6-astra β€’ Thinking: high

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: d56e01291b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

This comment has been minimized.

@ThomasK33
ThomasK33 added this pull request to the merge queue Sep 6, 2026
Merged via the queue into main with commit 9ae6477 Sep 6, 2026
36 of 39 checks passed
@ThomasK33
ThomasK33 deleted the model-config-0nmk branch September 6, 2026 17:09
yermakoffivan pushed a commit to yermakoffivan/mux that referenced this pull request Sep 9, 2026
## Summary

Version bump for the v0.28.5 patch release. Headline changes since
v0.28.4: remote server connections in the desktop app (coder#4101),
self-updating `xum server` under a restart supervisor (coder#4083, coder#4127),
first-class GPT-6 Astra and Astra Pro support including Codex OAuth
routing (coder#4064, coder#4094, coder#4106, coder#4124), token-budget context window
rollovers (coder#4097), the workspace remembering model and mode on send
(coder#3968), in-place plugin updates (coder#4164), the optional flat sidebar chat
list (coder#3994), and copying selected chat text as Markdown (coder#4170). It
also carries a long run of streaming, compaction, and task-lifecycle
fixes (reconnect streaming coder#4123, message edits during active streams
coder#4153, Codex OAuth prompt-cache routing coder#4159, compaction/history
fencing coder#4133 through coder#4148, task lock ordering coder#4161) plus the Effect
Wave 4 runtime refactors and deslop passes 1 through 3.

## Implementation

Bumped with `node ./scripts/set-package-version.js 0.28.5` so the root
`package.json` and the legacy `packages/mux-compat` forwarding package
stay version-locked. `src/common/compat/productIdentity.test.ts` passes
locally (8/8).

After this PR merges, the `v0.28.5` tag will be applied to the squash
commit and the GitHub Release published to trigger the
desktop/npm/docker pipelines.

---

_Generated with `xum` β€’ Model: `anthropic:claude-fable-5-1` β€’ Thinking:
`xhigh` β€’ Cost: `$1.64`_

<!-- mux-attribution: model=anthropic:claude-fable-5-1 thinking=xhigh
costs=1.64 -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant