🤖 fix: distinguish Codex status comments from unresolved findings - #4149
Conversation
Recognize authenticated known status and no-findings security envelopes in the shared cached/API classifier. Keep unknown protocol content and unresolved review threads blocking without changing approval signals. Run offline regression fixtures in the existing CI gate. Signed-off-by: Thomas Kosiewski <[email protected]> --- _Generated with `xum` • Model: `unavailable` • Thinking: `unavailable` • Cost: `$unavailable`_ <!-- mux-attribution: model=unavailable thinking=unavailable costs=unavailable --> Change-Id: I01cd3bf28b520725b348ba5f8c838a88ce41a1a1
This comment has been minimized.
This comment has been minimized.
|
@codex review Please review the narrow informational-comment classifier and its conservative protocol boundaries. This fixes the status-comment CI failure without granting approval from metadata or hiding unresolved review threads. Nine offline groups and full static validation pass; independent review approved. Existing legacy substring exemptions and approval-waiter behavior remain unchanged. Generated with |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
The automatic status card uses PR opened. Recognize that exact trigger and retain the original failing CI envelope as a regression fixture. API and cache paths fail before the correction and pass after it; all nine groups, live checker verification, and full static checks pass. Signed-off-by: Thomas Kosiewski <[email protected]> --- _Generated with `xum` • Model: `unavailable` • Thinking: `unavailable` • Cost: `$unavailable`_ <!-- mux-attribution: model=unavailable thinking=unavailable costs=unavailable --> Change-Id: I7fe7baa5226b04c3d6f8cb4174b097c7d00a088b
|
@codex review The first CI run exposed a missing observed trigger: the automatic status card says Generated with |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Security Review
Here are some automated security review suggestions for this pull request.
Reviewed commit: 6e13b33f0c
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
Raise only the unit job limit from 15 to 20 minutes. GitHub confirmed timeout exhaustion on two runs; one completed 15,738 tests with zero failures but exhausted the job budget during surrounding work. Recent healthy jobs already take 12-13 minutes. Keep commands, individual test timeouts and all other job settings unchanged. Parsed configuration comparison, actionlint and full static checks pass. Signed-off-by: Thomas Kosiewski <[email protected]> --- _Generated with `xum` • Model: `unavailable` • Thinking: `unavailable` • Cost: `$unavailable`_ <!-- mux-attribution: model=unavailable thinking=unavailable costs=unavailable --> Change-Id: I0ce0a0dfd06344688f239b771f501caa161ba772
|
@codex review The comment classifier now passes CI with the status card visible. The remaining failure was the unit job's 15-minute budget, confirmed by GitHub timeout annotations on jobs 102148183664 and 102145835219. The latter completed 15,738 tests with zero failures; recent green jobs take 12m49s and 13m13s. Comparison shows distributed runner slowdown rather than a new stalled test. Raise only the unit job limit to 20 minutes to cover setup, build, tests, coverage, and cleanup. Commands and individual test timeouts are unchanged, verified by parsed YAML comparison. This necessary CI correction is +3/-5 in the existing workflow; actionlint and full static checks pass. Classifier code is unchanged from your approved 6e13b33. Generated with |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Exempt a status summary only when its metadata and every review row are completed. Pending, mixed, and advisory-bearing summaries continue to block the checker. Completed summaries still do not provide approval. Ten false-pass assertions reproduce the original gap. All ten regression groups and full static checks pass, with independent review approval. Approval detection, waiter behavior, and legacy exemptions remain unchanged. Signed-off-by: Thomas Kosiewski <[email protected]> --- _Generated with `xum` • Model: `unavailable` • Thinking: `unavailable` • Cost: `$unavailable`_ <!-- mux-attribution: model=unavailable thinking=unavailable costs=unavailable --> Change-Id: I22aeec873bdb2c767640377b91c8c3451ffff186
|
Addressed security finding 3960253571: CI now exempts a status summary only when its metadata and every review row indicate completion. Running, queued, pending, mixed, and advisory-bearing summaries remain blocking. A completed summary still does not supply approval; the waiter and freshness checks are unchanged. Ten false-pass assertions reproduced the gap before the fix. All ten fixture groups and full static checks pass; independent review approved. Fixtures exercise real API and cached paths, independently pending metadata/rows, and the authenticated advisory summary. Its embedded finding remains blocking even when every status is completed. No Storybook or runtime changes were added. @codex review Generated with |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Reuse the classifier merged in #4149 without changing its blocking policy. Completed status and no-findings results remain pending until explicit approval, while findings and account errors still fail. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$24.58`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=24.58 -->
…oder#4151) ## Summary Follow up on coder#4149 so completed informational Codex results do not make the review waiter fail before its explicit approval signal arrives. The classifier fix merged while this PR was under review; this PR now preserves that implementation unchanged and contains only the missing waiter behavior and regression coverage. ## Implementation - Reuse the merged classifier to exclude authenticated, completed status summaries and clean-security envelopes from the waiter’s substantive-response count. - Keep polling for explicit approval rather than treating an informational result as either approval or a failed review. - Preserve the merged blocking policy for unfinished/unknown envelopes, real findings, unresolved threads, and account errors. ## Validation `make test-codex-comments` passes all 11 regression groups, including completed-result polling, stale/foreign approval signals, findings alongside informational comments, and account errors. `make static-check` passes. ## Risks This only changes the waiter’s non-terminal state; the CI classifier, comment-resolution checks, and approval/freshness requirements are unchanged. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$24.58`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=24.58 -->
> Stacked on coder#4151 (approval-waiter follow-up to the checker fix merged in coder#4149). Merge coder#4151 first; the diff against this PR's base remains spacing-only. ## Summary Keep all nested tool cards inset from the Code Execution border. The shared nested-tools container was cancelling its parent's horizontal padding with negative margins, so bordered cards such as `task_send_message` sat against the dashed frame. Removing that override fixes the shared layout rather than adding tool-specific spacing workarounds. ## Validation - Added full-app desktop and phone stories covering `agent_report`, `file_read`, and `task_send_message`, including collapsed/expanded message cards. Geometry assertions verify border clearance, separation between tools, and no horizontal overflow. - Confirmed the new tests fail before the fix (1px edge clearance) and pass afterward. Storybook-manager checks at 375px and 1280px measured 13px clearance on both sides. - `make static-check` passed; 7 full-app Storybook tests and 63 targeted tool-renderer/unit tests passed. <details> <summary>Existing local validation limitation</summary> The isolated `CodeExecutionToolCall` gallery has a Vite development-time circular-import error (`Cannot access 'CodeExecutionToolCall' before initialization`). Reproduced with the original production file as well. The full-app code-execution and agent-communication stories pass. </details> --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$24.54`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=24.54 -->
…oder#4223) ## Summary The `Codex Comments` gate treats Codex's review summary board as a blocking comment whenever it carries a "Security findings" section, even after every advisory thread is resolved and both reviews are complete. This whitelists the section when each advisory bullet carries Codex's own **Resolved** marker, so PRs that once had a security advisory can pass `Required` again. Unblocks coder#4211. ## Background Codex keeps resolved security advisories listed on the board and only adds the `· **Resolved**` marker when a later review completes (verified from the board's edit history on coder#4211: the marker appeared at the next review completion, not when the thread was resolved). The gate's line whitelist (coder#4149, coder#4158) does not know the section, so a completed board with resolved advisories is reported as an unresolved Codex comment and `Required` can never go green. On coder#4211 the gate log at 17:24Z shows exactly that: `status: completed`, both rows Completed, two `**Resolved**` advisories, still counted as blocking. The two most recent merged PRs with such boards (coder#4170, coder#4176) only passed because the section was added after their last gate run. ## Implementation `scripts/lib/codex_comments.jq` accepts three more line shapes inside a completed board: `### Security findings`, `#### Advisory findings (N)`, and a bullet that links a review thread on a PR (`.../pull/N#discussion_r<id>`), names a severity, and ends with `· **Resolved**`. A bullet without the marker is a live finding and keeps blocking, as do unknown sections, non-thread links, and trailing text. ## Validation - `python3 scripts/check_codex_comments_test.py`: the existing unresolved-advisory case still expects blocking; new cases cover the resolved board (informational) and three malformed variants (still blocking). Red without the jq change: the resolved case fails `1 != 0`. - The new jq evaluated against real boards: coder#4211's completed board with two resolved advisories is informational; its running board and coder#4176's board (unresolved advisory) stay blocking. --- _Generated with `xum` • Model: `anthropic:claude-fable-5-1` • Thinking: `xhigh` • Cost: `$16.42`_ <!-- mux-attribution: model=anthropic:claude-fable-5-1 thinking=xhigh costs=16.42 -->
Codex posts an editable review-status summary and a separate no-findings security report. The unresolved-comments gate counts both as findings, so approved PRs fail CI until someone manually minimizes those informational comments.
Recognize completed authenticated status/no-findings envelopes in the classifier shared by cached and paginated GitHub data. Both metadata and every review row must indicate completion; unfinished and mixed summaries remain blocking. Unknown metadata, extra finding text, and unresolved review threads remain blocking. Status comments never supply approval; the approval waiter and freshness checks are unchanged. Existing legacy approval/rate-limit substring exemptions remain unchanged.
Ten offline regression groups exercise the real checker and waiter, including automatic
PR openedand manual summaries, mixed review states, security findings, extra text inside or after help footers, unknown payloads, author boundaries, pagination, cache refresh, and stale approval. The existing Codex Comments job runs those fixtures through a Make target. Completed informational cards may stay visible without blocking; live advisory-bearing cards correctly remain blocking.CI validation also exposed the unit job exhausting its 15-minute limit. GitHub timeout annotations confirmed two affected runs; one finished 15,738 tests with zero failures before its job budget expired. Raise only that limit to 20 minutes, retaining individual test timeouts and commands, to allow setup, build, coverage, and cleanup.
Validation: all ten regression groups, direct live checker verification, actionlint, and full static checks pass. Parsed YAML comparison confirms no other job settings changed. Independent review approved the completed-only classifier. Nix formatting was skipped because Nix is unavailable. No Effect runtime changes.
Generated with
xum• Model:unavailable• Thinking:unavailable• Cost:$unavailable