fix: remove null from useHtmlIframeProps return signature (dead condition)

jsamr · jsamr · commit 4c51d0af641c · 2021-10-12T10:51:21.000-03:00
diff --git a/packages/iframe-plugin/docs/iframe-plugin.usehtmliframeprops.md b/packages/iframe-plugin/docs/iframe-plugin.usehtmliframeprops.md
@@ -9,7 +9,7 @@ Extract props for the HTMLIframe component from renderer function arguments. Thi
 <b>Signature:</b>
 
 ```typescript
-export default function useHtmlIframeProps({ style, tnode }: CustomRendererProps<TBlock>, iframeConfig?: IframeConfig): HTMLIframeProps | null;
+export default function useHtmlIframeProps({ style, tnode }: CustomRendererProps<TBlock>, iframeConfig?: IframeConfig): HTMLIframeProps;
 ```
 
 ## Parameters
@@ -21,5 +21,5 @@ export default function useHtmlIframeProps({ style, tnode }: CustomRendererProps
 
 <b>Returns:</b>
 
-[HTMLIframeProps](./iframe-plugin.htmliframeprops.md) \| null
+[HTMLIframeProps](./iframe-plugin.htmliframeprops.md)
 
diff --git a/packages/iframe-plugin/etc/iframe-plugin.api.md b/packages/iframe-plugin/etc/iframe-plugin.api.md
@@ -49,7 +49,7 @@ const IframeRenderer: CustomBlockRenderer;
 export default IframeRenderer;
 
 // @public
-export function useHtmlIframeProps({ style, tnode }: CustomRendererProps<TBlock>, iframeConfig?: IframeConfig): HTMLIframeProps | null;
+export function useHtmlIframeProps({ style, tnode }: CustomRendererProps<TBlock>, iframeConfig?: IframeConfig): HTMLIframeProps;
 
 
 // (No @packageDocumentation comment for this package)
diff --git a/packages/iframe-plugin/src/useHtmlIframeProps.ts b/packages/iframe-plugin/src/useHtmlIframeProps.ts
@@ -31,7 +31,7 @@ const defaultIframeConfig: IframeConfig = {
 export default function useHtmlIframeProps(
   { style, tnode }: CustomRendererProps<TBlock>,
   iframeConfig?: IframeConfig
-): HTMLIframeProps | null {
+): HTMLIframeProps {
   const {
     WebView,
     defaultWebViewProps,
@@ -89,20 +89,13 @@ export default function useHtmlIframeProps(
         })
       };
 
-  if (__DEV__ && !WebView) {
-    console.warn(
-      "@native-html/iframe-plugin: You must pass a WebView component from react-native-webview as a prop to the HTML component. The iframe won't be rendered."
-    );
-  }
-  return WebView
-    ? {
-        ...resolvedConfig,
-        source,
-        onLinkPress,
-        htmlAttribs,
-        scaleFactor,
-        style: [restStyle, { width: printWidth, height: printHeight }],
-        WebView
-      }
-    : null;
+  return {
+    ...resolvedConfig,
+    source,
+    onLinkPress,
+    htmlAttribs,
+    scaleFactor,
+    style: [restStyle, { width: printWidth, height: printHeight }],
+    WebView
+  };
 }
