Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feature:cloudcmd:add context menu option to toggle file selection #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

hagaygo
Copy link
Contributor

@hagaygo hagaygo commented Oct 25, 2024

Adds option 3 of suggestions on #418

I selected an existing icon that i thought is good enough for this context menu option.

Could not manage to add new icon so far, needs some pointers in adding new icon (added one in the svg file and fontello.json , but it did not work)

  • npm run fix:lint is OK
  • npm test is OK

@coderaiser
Copy link
Owner

We need to choose an icon in fontello.com. Do you have any ideas?

@hagaygo
Copy link
Contributor Author

hagaygo commented Oct 26, 2024

I think something like check mark would fit.

One of these for example

IMG_20241026_071233_262.jpg

@coderaiser
Copy link
Owner

Landed in v18.2.0 🎉

@hagaygo hagaygo deleted the toggle-selection-context-menu branch October 27, 2024 15:15
@hagaygo
Copy link
Contributor Author

hagaygo commented Oct 27, 2024

While the feature does work , i missed the fact that on mobile we don't have up/down buttons and when clicking on the "next file" in the list it resets the selection, so its not possible yet to multi select files on mobile UI. (still the feature is really useful on desktop mode)

Also long press already shows the context menu.

I think the next change should be is to disable the existing selected files reset totally or only on mobile UI/view when the user click on a file on the list.

Then the user will be able to select file 1 , long click to open context , toggle the selection , click on file 2 , toggle the selection and so on.

Other options is to add up/down buttons on the bottom on mobile view , which will allow the user to navigate on the list without triggering the selection reset, i think this is also nice to have regardless the missing feature above.

Let me know if i should try to implement those features or you have a better idea.

@coderaiser
Copy link
Owner

I don’t have a better idea, let’s try the simplest variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants