This repository was archived by the owner on May 9, 2020. It is now read-only.
Replace urllib2 with requests, add option to disable SSL cert verification #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,6 +56,8 @@ class ChefAPI(object): | |||
| env_value_re = re.compile(r'ENV\[(.+)\]') | |||
| ruby_string_re = re.compile(r'^\s*(["\'])(.*?)\1\s*$') | |||
|
|
|||
| verify_ssl = True | |||
There was a problem hiding this comment.
Please set the in the initialize. Using class MRO callback for default instance values is a really bad pattern.
|
My second commit brings everything in line with the comments. I've been running this quite happily now for over a week in my production environment. Anything else required to merge this? Adding PR #37 fixes the tests on my local branch. |
|
Looks good, thanky! |
coderanger
added a commit
that referenced
this pull request
Sep 10, 2015
Replace urllib2 with requests, add option to disable SSL cert verification
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have problems with our internally hosted chef server's SSL cert not being real, which is fine for us not facing the internet. Trying to disable validation with urllib2 is quite messy, so this patch: