Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit b17b2ea

Browse files
jimfbzpao
authored andcommitted
Merge pull request facebook#6152 from jimfb/fix-blog-code-fragment
Updated code fragment for correctness. (cherry picked from commit 56c423a)
1 parent 25fdaf9 commit b17b2ea

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

docs/_posts/2015-12-16-ismounted-antipattern.md

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,17 @@ Where `makeCancelable` is [defined by @istarkov](https://github.com/facebook/rea
6060
const makeCancelable = (promise) => {
6161
let hasCanceled_ = false;
6262

63+
const wrappedPromise = new Promise((resolve, reject) => {
64+
promise.then((val) =>
65+
hasCanceled_ ? reject({isCanceled: true}) : resolve(val)
66+
);
67+
promise.catch((error) =>
68+
hasCanceled_ ? reject({isCanceled: true}) : reject(error)
69+
);
70+
});
71+
6372
return {
64-
promise: new Promise(
65-
(resolve, reject) => promise
66-
.then(r => hasCanceled_
67-
? reject({isCanceled: true})
68-
: resolve(r)
69-
)
70-
),
73+
promise: wrappedPromise,
7174
cancel() {
7275
hasCanceled_ = true;
7376
},

0 commit comments

Comments
 (0)