Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Mar 9, 2021. It is now read-only.

Adjust padding #77

Closed
M-ZubairAhmed opened this issue Nov 6, 2017 · 18 comments
Closed

Adjust padding #77

M-ZubairAhmed opened this issue Nov 6, 2017 · 18 comments

Comments

@M-ZubairAhmed
Copy link

Current status

image
The content loader for text is far off to the left. While on web view it looks correct on mobile view its a bit off.

Possible Solution

  • Adjust the padding of that particular content loader to match web view
  • Related files are under components/content-loaders , pages/events
@pbteja1998
Copy link
Member

pbteja1998 commented Nov 6, 2017

Also I think alignment should be adjusted in the mobile view of "Coming Soon" section. Look at the following image
padd

@vinaypuppal
Copy link
Contributor

vinaypuppal commented Nov 6, 2017

@pbteja1998 Instead of padding that text should be center aligned.


And this should also be fixed, these cards should be center aligned horizontally.
screen shot 2017-11-06 at 21 32 30

@pbteja1998
Copy link
Member

pbteja1998 commented Nov 6, 2017

@vinaypuppal, edited my comment. Also the cards are center aligned in my mobile. Maybe that is happening in only some of the mobiles.

@vinaypuppal
Copy link
Contributor

@pbteja1998 Yes for screen sizes below 725px width(updated the image with responsive view)

@elevenpassin
Copy link
Collaborator

elevenpassin commented Nov 6, 2017

Hmm I'll take this, assign me in!
also @vinaypuppal @M-ZubairAhmed MORE ISSUES

@vinaypuppal
Copy link
Contributor

@buoyantair Yeah sure

@elevenpassin
Copy link
Collaborator

elevenpassin commented Nov 6, 2017

@vinaypuppal Just checked out projects, why not add issues for top features.. =3 set up a dummy api and db and let others work on dashboard or profiles etc =3 instead of just bug fixes and style fixes

@M-ZubairAhmed
Copy link
Author

@buoyantair currently its more of trying out things and then working up from there. So we plan the features then work towards it in separate branch. If we feel like feature can be discusses we open a discussion issue

@elevenpassin
Copy link
Collaborator

@M-ZubairAhmed Ok

@elevenpassin
Copy link
Collaborator

@M-ZubairAhmed I'm getting this weird error when I tried to build
https://pastebin.com/URG70SfL

@M-ZubairAhmed
Copy link
Author

can you try with more recent version of node eg 8 or 9.
i recomend using node version manager.
if the problem still persist can you explains steps to reproduce

@elevenpassin
Copy link
Collaborator

@M-ZubairAhmed Im using 9.0.0 for nodejs and In order to reproduce the bug, just run build

@M-ZubairAhmed
Copy link
Author

@buoyantair could you push to pr? we can take a look from there

@pbteja1998
Copy link
Member

pbteja1998 commented Nov 7, 2017

@buoyantair Did you try reinstalling the node modules again, because your error log says that it could not resolve marked. I think a simple npm install might solve the problem. Why not try this once?

@elevenpassin
Copy link
Collaborator

@M-ZubairAhmed @pbteja1998 I tried to rewrite it like this
from
import marked from 'marked';
to
import * as marked from 'marked';

Still doesnt work

@pbteja1998
Copy link
Member

Does npm list --depth=0 has marked package ?

@elevenpassin
Copy link
Collaborator

@M-ZubairAhmed Make this issue open, I'm kind of busy to work on this right now :/

@M-ZubairAhmed
Copy link
Author

closing as its not relevant anymore

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants