Events page updated #11
Conversation
|
@M-ZubairAhmed is it possible for you to host this somewhere and share a demo link, so that people can interact with the what you've created? |
|
@duttakapil we have mentioned how to run the dev server in our readme i guess developers should be able to run a local copy. |
package.json
Outdated
| }, | ||
| "lint-staged": { | ||
| "*.js": [ | ||
| "prettier --write --single-quote --print-width=80 --trailing-comma=all", | ||
| "prettier --write --single-quote --print-width=80 --trailing-comma=all --no-semi", |
There was a problem hiding this comment.
Why did you disable semicolons?
There was a problem hiding this comment.
more of a coding style and also one less thing to worry about
There was a problem hiding this comment.
If you don't like semicolons then you don't type them in code, let tools like prettier and xo place them at the time of committing(which will be taken care by pre-commit hook lint-staged).
|
@M-ZubairAhmed It has lot of unrelated changes would you revert them back and submit a new PR with just event page updates. BTW if you don't like semicolons then you don't type them in code, let tools like prettier and xo place them at the time of committing(which will be taken care by pre-commit hook |
common/urls.js
Outdated
| @@ -0,0 +1,5 @@ | |||
| export const pastEventsMeetupURL = | |||
There was a problem hiding this comment.
Move this file under utils folder
components/row-events.js
Outdated
| width: '800px', | ||
| backgroundColor: '#fafafa', | ||
| }} | ||
| > |
There was a problem hiding this comment.
Please move all inline styles to <style jsx> tag
package.json
Outdated
| }, | ||
| "lint-staged": { | ||
| "*.js": [ | ||
| "prettier --write --single-quote --print-width=80 --trailing-comma=all", | ||
| "prettier --write --single-quote --print-width=80 --trailing-comma=all --no-semi", |
There was a problem hiding this comment.
If you don't like semicolons then you don't type them in code, let tools like prettier and xo place them at the time of committing(which will be taken care by pre-commit hook lint-staged).
pages/events.js
Outdated
| pastEvents: requestPastEvents.data, | ||
| futureEvents: requestFutureEvents.data, | ||
| }) | ||
| NProgress.done() |
There was a problem hiding this comment.
Please move this logic to getInitialProps so page can be Server Side Rendered. More Info https://github.com/zeit/next.js/#fetching-data-and-component-lifecycle
pages/events.js
Outdated
| }} | ||
| > | ||
| <h1 | ||
| style={{ |
There was a problem hiding this comment.
Move inline styles to <style jsx>
|
This is the preview url https://coderplex-app-assdaiebwd.now.sh/events |
|
@M-ZubairAhmed There seems some CORS issue in above url page is not loading events |
|
yes, i raised the issue #9 |
|
@M-ZubairAhmed Its not related to our backend, its from meetup API. Maybe we can do a call and I can explain this |
.gitignore
Outdated
|
|
||
| # generate lock files | ||
| package-lock.json |
There was a problem hiding this comment.
package-lock.json should not be ignored. And we should both either use either yarn or npm only not both. As this repo already has yarn.lock file so you should continue with it.
Demo link (updated) |
As per the new design mock up event page design updated