This repository was archived by the owner on Mar 9, 2021. It is now read-only.
Single upcoming event to be shown #124
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for opening your first PR here! |
|
Deploy preview ready! Built with commit 7c3906b |
M-ZubairAhmed
suggested changes
Dec 13, 2017
| @@ -30,7 +30,7 @@ export default class Events extends React.Component { | |||
| pastEvents: [], | |||
| pastEventsLoadLimit: 2, | |||
| futureEvents: [], | |||
| futureEventsLoadLimit: 2, | |||
| futureEventsLoadLimit: 1, | |||
There was a problem hiding this comment.
We arent looking at this to change.
|
@M-ZubairAhmed I do not ReactJS so I am not able to get how to use that in the index.js file. Can you tell me what I should do. |
|
@chotuaashiq its inspiring that you would want to contribute, i would suggest you go through this ReactJS and look for components section. We have prepared a curated list of all react best learning resource. Also there is a webcast today where we are going to explain our code base. I would like to invite you for that and you can also ask lots of questions live. |
|
ping! |
|
Closing this for #133 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#118 I changed the loadlimit size for the upcoming events to be 1.
@M-ZubairAhmed @pbteja1998 Please review.
--
Checklist for this PR
yarn lintlocally to format my code.yarn testran successfully.developbranch.