Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Mar 9, 2021. It is now read-only.

refactor(row-events): fixed attendance terminology and applied minor styling for mobile view #20

Merged
merged 2 commits into from
Oct 18, 2017
Merged

refactor(row-events): fixed attendance terminology and applied minor styling for mobile view #20

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f6dc30
refactor(row-events): upcoming events will show 'attending' while rec…
jberry93 Oct 18, 2017
1f2dda0
refactor(props): added status prop to row-events component to determi…
jberry93 Oct 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions components/row-events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,13 @@ const RowEvent = props => {
</span>
<span className="card_icons">
<Icon name="users" />
{`${props.yesCount} attended`}
{props.yesCount}
{moment(props.time).isAfter() ? ' attending' : ' attended'}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a very clever way of doing but in the object of props we are receiving status key,
image
Do you mind checking that props and getting attending or attended terminology

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see! So something like...

props.status === 'upcoming' ? ' attending' : ' attended'

...would be more ideal? I'll commit and push when I've time tomorrow. Thanks for the fast reply

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes thank for helping out. Also for faster processing for PR, if it is major feature change or something, We encourage people to deploy it to Now.sh and share the link.

  • install now-cli npm i -g now and run now inside that directory and follow instructions to login as this first time
  • thats it just one command and app is deployed
  • after app is deployed you can alias your now.sh deployment to PR number like coderplex-pr-11.now.sh and for every changes run now and after completion run now alias <url> coderplex-pr-11.now.sh to update it

Copy link

@M-ZubairAhmed M-ZubairAhmed Oct 18, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://coderplex-app-pr20.now.sh/events

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this matter can go into Contributing docs

</span>
<span className="card_icons">
<Icon name="log out" />
{props.venue === undefined ? 'Free session' : 'Free entry'}
</span>
<Icon name="log out" />
{props.venue === undefined ? 'Free session' : 'Free entry'}
</Card.Content>
<style jsx>{`
.card_venue {
Expand All @@ -32,6 +35,12 @@ const RowEvent = props => {
.card_icons {
margin-right: 15px;
}
@media (max-width: 700px) {
.card_icons {
display: flex;
margin: 5px 0;
}
}
`}</style>
</Card>
);
Expand Down