Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Mar 9, 2021. It is now read-only.

updated details on coderplex/space page #218

Merged
merged 3 commits into from
Jul 25, 2018
Merged

updated details on coderplex/space page #218

merged 3 commits into from
Jul 25, 2018

Conversation

charan1922
Copy link
Contributor

What kind of change does this PR introduce

What is the current behavior

What is the new behavior

Checklist for this PR

  • I have read contributing guidelines.
  • I executed yarn lint locally to format my code.
  • I added revelant Tests to verify my code.
  • All tests yarn test ran successfully.
  • Pull request is towards develop branch.
  • I have tested responsiveness of the UI by checking on devices using ScreenFly
  • Added myself to contributors table
  • Documentation
  • Ready to be merged

@welcome
Copy link

welcome bot commented Jul 25, 2018

Thanks so much for opening your first PR here!

@coderplex-bot
Copy link
Collaborator

coderplex-bot commented Jul 25, 2018 •
edited
Loading

Deploy preview for coderplex failed.

Built with commit d0bf65b

https://app.netlify.com/sites/coderplex/deploys/5b58c403b31274197293e48e

@vinaypuppal
Copy link
Contributor

vinaypuppal commented Jul 25, 2018 •
edited
Loading

@charan1922 Looks good. Few things to keep in mind for next time

  1. Please fill Pull request template while creating new PR's
  2. Please add your name to the contributors' list. Follow this guide to do so https://github.com/coderplex/coderplex/blob/develop/.github/CONTRIBUTING.md#add-yourself-as-a-contributor

Please complete 2 from above for this PR and so we can merge it.

@vinaypuppal vinaypuppal merged commit 8495145 into coderplex-org:develop Jul 25, 2018
@welcome
Copy link

welcome bot commented Jul 25, 2018

🎉 🎉 🎊 Congrats on merging your first pull request! We here at coderplex.org are proud of you!. If you believe in our 📃 mission statement please ⭐ us.

@vinaypuppal
Copy link
Contributor

Please complete 2 from above for this PR and so we can merge it.

Nevermind I added you as the contributor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vinaypuppal vinaypuppal vinaypuppal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@charan1922 @coderplex-bot @vinaypuppal @charan-cp