This repository was archived by the owner on Mar 9, 2021. It is now read-only.
Move Subscribe to extern component #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit b2d078c |
|
@HerrVoennchen thank you for the work, we are reviewing your changes |
|
@HerrVoennchen Thanks for your contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
happy hacktoberfest, this is my take on issue #40. I moved the Subscribe Section to a seperate component. Since it uses in-component-styles may some css classes are doubled, so another issue can be to solve this. I have not much experience with in-component-styles because most projects I still stick to the "old" way with seperate files (and because the use of sass/less).
I also fixed the error property on the semantic ui form. It takes a bool to show the error Message.
let me know if something is missing or should be corrected, I'll happy to do that.
I hat looked into the issues linked in #40, but one is already closed and the other for styling suggestions, well I quite like like it looks now and I'm sadly not a design geek and have no better idea of styling. May the footer background color should match more the way the top/header look like, that purple tone. :)
regards,
Sebastian