This repository was archived by the owner on Mar 9, 2021. It is now read-only.
#37 multiline span on landing page in events card #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit fc99f74 |
M-ZubairAhmed
suggested changes
Oct 25, 2017
|
I have added logic for selective multi-line using prop. For the RowEvent component on landing page, isMutliLine set to true is passed. |
M-ZubairAhmed
suggested changes
Oct 25, 2017
M-ZubairAhmed
approved these changes
Oct 25, 2017
|
thanks thats great work. Please do checkout issues space from time to time. |
|
Formatting changes got included in the earlier commit for package.json and package-lock.json. I have not added any additional dependency. Thanks :) @M-ZubairAhmed. I will keep a check on the latest issues |
|
@abiduzz420 yes I have accepted, but its generally a good practice to only include the files which you have worked on in the pr. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.