open learn guide in new tab #81
Conversation
|
Deploy preview ready! Built with commit e25190c |
|
fixes #79 |
| href={`/learn/subject?id=${subject.subjectId}`} | ||
| as={subject.url} | ||
| <Card | ||
| href={subject.url} |
There was a problem hiding this comment.
@pbteja1998 As we are using not using <Link/> component we loose client side navigation i.e the client sends a request to sever for this new page to load. Which is waste as we can reuse previously loaded client side bundle (where as with client side routing we only load js bundle data required to show new page). You can see this by opening chrome devtools -> Network Tab and compare above demo link and https://coderplex.org/learn
So we don't want to remove <Link/> component and it is not what causing this issue. Semantic-ui-react's <Card/> is what preventing right-click so can you debug whats wrong with it. Thanks
There was a problem hiding this comment.
So our team's official policy (for now) is:
We only use Yarn as our official Node package manager, and so we will only commit yarn.lock files.
So please use Yarn instead of npm we don't want both yarn.lock and package-lock.json files in the repo.
Linkand addedhrefattribute toCard