Implement validators for users and projects

elevenpassin · elevenpassin · commit 1b72d66fb349 · 2018-08-29T11:58:04.000+05:30
diff --git a/models/User.js b/models/User.js
@@ -1,18 +1,35 @@
 const mongoose = require('mongoose')
 const { Schema } = mongoose
 
+const {
+  linkType
+} = require('./validators')
+
 const UserSchema = new Schema({
   username: {
     type: String,
-    required: true
+    required: [true, 'username is required!'],
+    unique: true,
+    validate: {
+      validator: async (v) => {
+        return /^[\w\d]+$/ig.test(v)
+      },
+      message: props => `${props.value} is not a valid username!`
+    }
   },
   email: {
     type: String,
-    required: true
+    validate: {
+      validator: async (v) => {
+        return /^[\d\w]+@[\d\w]+\.[\w]+$/ig.test(v)
+      },
+      message: props => `${props.value} is not a valid email address!`
+    },
+    required: [true, 'email is required!']
   },
   password: {
     type: String,
-    required: true,
+    required: [true, 'password is required!'],
     minlength: 10
   },
   mobile: {
@@ -27,14 +44,14 @@ const UserSchema = new Schema({
   working: Boolean,
   forhire: Boolean,
   links: {
-    facebook: String,
-    twitter: String,
-    linkedin: String,
-    angellist: String,
-    stackoverflow: String,
-    codepen: String,
-    github: String,
-    behance: String,
+    facebook: linkType,
+    twitter: linkType,
+    linkedin: linkType,
+    angellist: linkType,
+    stackoverflow: linkType,
+    codepen: linkType,
+    github: linkType,
+    behance: linkType,
     discord: String
   },
   techFamiliarWith: [String],
diff --git a/models/UserProject.js b/models/UserProject.js
@@ -1,6 +1,8 @@
 const mongoose = require('mongoose')
 const { Schema } = mongoose
 
+const { linkType } = require('./validators')
+
 const UserProjectSchema = new Schema({
   name: {
     type: String,
@@ -15,15 +17,15 @@ const UserProjectSchema = new Schema({
     maxlength: 1000
   },
   thumbnailUrl: {
-    type: String,
+    ...linkType,
     default: 'Some url to default thumbnail'
   },
   creators: {
     type: [Schema.Types.ObjectId],
     required: true
   },
   link: {
-    type: String,
+    ...linkType,
     required: true
   },
   hits: {
diff --git a/models/validators.js b/models/validators.js
@@ -0,0 +1,16 @@
+function linkValidator (value) {
+  return /https?:\/\/(w{3}\.)?[\w\d]+\..+/.test(value)
+}
+
+const linkType = {
+  type: String,
+  validate: {
+    validator: linkValidator,
+    message: 'please provide a valid link'
+  }
+}
+
+module.exports = {
+  linkValidator,
+  linkType
+}
diff --git a/resolvers/index.js b/resolvers/index.js
@@ -38,7 +38,14 @@ const resolvers = {
           throw new Error(`A user with the username ${username} already exists`)
         }
 
-        return new User(user).save()
+        const newUser = new User(user)
+        const isInvalid = await newUser.validate()
+
+        if (isInvalid) {
+          throw isInvalid
+        }
+
+        return newUser.save()
       } catch (e) {
         throw e
       }
