Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Oct 14, 2020. It is now read-only.

C++ Support #174

Merged
merged 27 commits into from
Jun 3, 2016
Merged

C++ Support #174

merged 27 commits into from
Jun 3, 2016

Conversation

Dan-Nolan
Copy link
Contributor

@Dan-Nolan Dan-Nolan commented Jun 1, 2016

  • Adds C++ support with Igloo BDD testing
  • Fixes C# issue Codewars #5

@Dan-Nolan
Copy link
Contributor Author

Addresses #10

@jhoffner
Copy link
Member

jhoffner commented Jun 2, 2016

Are we still missing the <:LF:> line break replacement token in this? Also what version of C++ is it running?

@Dan-Nolan
Copy link
Contributor Author

Just added the <LF::>, and we're at C++ 14 :)

@jhoffner
Copy link
Member

jhoffner commented Jun 2, 2016

CI failures

  10 passing (9s)
  2 failing

  1) cpp runner .run should handle basic code evaluation:

      Uncaught AssertionError: expected '' to equal '"Within C++, there is a much smaller and cleaner language struggling to get out." - Bjarn Stroustrup'
      + expected - actual

      +"Within C++, there is a much smaller and cleaner language struggling to get out." - Bjarn Stroustrup

      at test/runners/cpp_spec.js:14:42
      at lib/shovel.js:37:13
      at ChildProcess.<anonymous> (lib/shovel.js:178:9)
      at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12)

  2) cpp runner .run igloo bdd should handle inheritance like a champ:
     Uncaught AssertionError: expected '' to include '<DESCRIBE::>inheritance_tests'
      at test/runners/cpp_spec.js:309:46
      at lib/shovel.js:37:13
      at ChildProcess.<anonymous> (lib/shovel.js:178:9)
      at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12)

@Dan-Nolan
Copy link
Contributor Author

Not really sure how those two examples are related and it's working locally. I'll try rebuilding and seeing if I can reproduce it somehow...

@jhoffner
Copy link
Member

jhoffner commented Jun 3, 2016

👍 🎉 🍔

@jhoffner jhoffner merged commit a838bc7 into codewars:master Jun 3, 2016
kazk added a commit to codewars/igloo that referenced this pull request Nov 24, 2019
kazk added a commit to codewars/igloo that referenced this pull request Nov 24, 2019
kazk added a commit to codewars/igloo that referenced this pull request Nov 24, 2019
kazk added a commit to codewars/igloo that referenced this pull request Nov 24, 2019
kazk added a commit to codewars/igloo that referenced this pull request Nov 24, 2019
kazk added a commit to codewars/igloo that referenced this pull request Nov 24, 2019
kazk added a commit to codewars/igloo that referenced this pull request Nov 24, 2019
kazk added a commit to codewars/igloo that referenced this pull request Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants