Extract inline fragments from HTML markup #1801
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neSpecc
reviewed
Oct 18, 2021
| * @private | ||
| */ | ||
| public insertInlineFragments(data: Pick<SavedData, 'data'>, fragmentsDict: InlineFragmentsDict): Pick<SavedData, 'data'> { | ||
| const insertToString = (str: string, fragments: InlineFragment[]): string => { |
There was a problem hiding this comment.
It could be moved to the utility method
| startOffset = fragment.range[0] - offset; | ||
| } | ||
|
|
||
| if (!endNode && offset + node.textContent.length >= fragment.range[1]) { |
There was a problem hiding this comment.
duplicated code fragment, could be moved to the function
| return template.innerHTML; | ||
| }; | ||
|
|
||
| const insert = (dataToProcess: Record<string, unknown>, fragments: InlineFragmentsDict): Pick<SavedData, 'data'> => { |
There was a problem hiding this comment.
It could be moved to the utility method
| return; | ||
| } | ||
|
|
||
| if (typeof value === 'object') { |
There was a problem hiding this comment.
use our internal isObject method
| if (typeof value === 'string') { | ||
| dataToProcess[key] = insertToString(value, fragments[key] as InlineFragment[]); | ||
| } | ||
| }); |
There was a problem hiding this comment.
what if value is another type? number, function, promise etc?
src/components/modules/saver.ts
Outdated
| return Tools.blockTools.get(name).sanitizeConfig; | ||
| }); | ||
| const withFragments = sanitizedData.map(savedData => { |
There was a problem hiding this comment.
comment needed. Maybe could be moved to the separate method
| case Node.ELEMENT_NODE: { | ||
| const length = node.textContent.length; | ||
| const fragment: InlineFragment = { | ||
| range: [offset, offset + length], |
| * @private | ||
| */ | ||
| private extractInlineFragments(data: Pick<SavedData, 'data'>): InlineFragmentsDict { | ||
| const extractFromString = (str: string): InlineFragment[] => { |
| attributes: Object.fromEntries(Array.from((node as HTMLElement).attributes).map(attr => ([attr.nodeName, attr.nodeValue]))), | ||
| }; | ||
|
|
||
| fragments.push(fragment); |
There was a problem hiding this comment.
what if a fragment contains its own children with fragments?
| @@ -0,0 +1,9 @@ | |||
| export interface InlineFragment { | |||
…lean-inline-fragments
…lean-inline-fragments
…lean-inline-fragments
|
Todo list:
|
…lean-inline-fragments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.