fix(v4): toJSONSchema tuple path handling for draft-7 with metadata IDs #5152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olinhacks#5151 Adds test that exposes bug where tuple schemas with rest elements and metadata IDs generate incorrect internal paths when targeting draft-7, causing improper schema extraction and reference generation.
Fixes issue colinhacks#5151 where tuple schemas with rest elements and metadata IDs generated incorrect internal paths when targeting draft-7, causing improper schema extraction and reference generation. The bug was in hardcoded path names regardless of JSON Schema target: - draft-2020-12 should use "prefixItems" and "items" - draft-7/draft-4 should use "items" and "additionalItems" - openapi-3.0 should use indexed "items"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5151
Resolves issue where tuple schemas with rest elements and metadata IDs generated incorrect internal paths when targeting draft-7, causing improper schema extraction and reference generation.
Changes