Update GPSTransform calculations to improve accuracy #1132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freeverc
reviewed
Nov 16, 2021
Contributor
Freeverc
left a comment
There was a problem hiding this comment.
The gps test is in wrong logic now.
| a_ = 6378137.0; | ||
| // Using flattening factor and semi-minor axis calculation from Bing maps. | ||
| // New calculations are marginally more accurate than the original values. | ||
| f_ = 1.0 / 298.257222101; |
Contributor
There was a problem hiding this comment.
Accurate f of WGS84 is 1.0 / 298.257223563. You are using a wrong value here,which comes from GRS80(1.0 /
298.2572221008827112431628366). Please refer to https://en.wikipedia.org/wiki/World_Geodetic_System
Contributor
There was a problem hiding this comment.
@Freeverc Thanks for detecting this issue. Would you be able to submit a fix to revert back ?
| 4.7282674046563692e6); | ||
| ref_xyz.emplace_back(4.1772186604902023e6, 0.8551759313518483e6, | ||
| 4.7282818502697079e6); | ||
|
|
Contributor
There was a problem hiding this comment.
The test case is for GRS80 not WGS84!
lucasthahn
pushed a commit
to tne-ai/colmap
that referenced
this pull request
Aug 17, 2022
Co-authored-by: Antonios Matakos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.