Refactoring and new functionality in Reconstruction class #1169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This new functionality is leveraged in additional model manipulation commands that will be part of subsequent PR. |
anmatako
commented
Mar 9, 2021
anmatako
commented
Mar 9, 2021
ahojnnes
reviewed
Mar 9, 2021
ahojnnes
reviewed
Mar 9, 2021
ahojnnes
reviewed
Mar 9, 2021
ahojnnes
reviewed
Mar 9, 2021
ahojnnes
reviewed
Mar 9, 2021
ahojnnes
reviewed
Mar 9, 2021
Contributor
Author
|
I'll add some unit tests for the new functionality in the next update and it should be good then. |
ahojnnes
reviewed
Mar 10, 2021
lucasthahn
pushed a commit
to tne-ai/colmap
that referenced
this pull request
Aug 17, 2022
* Refactoring and new functionality in Reconstruction class * Change set to unordered_set * Address PR comments * Add unit tests * Make Reconstruction Crop test deterministic * Update reconstruction.cc Co-authored-by: Antonios Matakos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New functionality:
ComputeBoundsAndCentroid: Computes the bounding box (two corner points) of the reconstruction and the 3D point centroid based on the min and max percentiles. Similarly to howNormalizeworks.ComputeCentroid: Computes the centroid based on the min and max percentiles.ComputeBoundingBox: Computes the bounding box as two corner points based on the min and max percentiles.Crop: Crops the reconstruction based on the given bounding box. It does not modify the current reconstruction; the cropped result is an output by reference instead. The output reconstruction only includes the 3D points within the bounding box. It includes all images and cameras of the original reconstruction, but only the images that see 3D points inside the bounding box are registered.Modified functionality:
Normalize: Works same as before but now leverages the newComputeBoundsAndCentroidfunction.AlignandAlignRobust: These are now templated on a bool flag that determines whether or not the scale is estimated when estimating the similarity transform. Also they can export the transform used in alignment since it's now provided as input by reference.