Use FindCUDAToolkit when available. #1693
Merged
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you. |
|
Failed to build on my Ubuntu 22.04. |
Contributor
|
@takeru Could you post an error Message or would you have time to submit a fix? Thank you. |
While the build does not fail for me the method fails to build something with CUDA support: When I force Using I am on Ubuntu 22.04. |
That's what I meant. |
|
Also failed on Arch Linux, with CUDA 11.8 and cmake 3.25.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using find_package resulted in missing CUDA::cudart, CUDA::cublas, etc, from my machine.
WSL Ubuntu 20, CMake 3.24, CUDA 12.
Using find_package(CUDAToolkit) solved this issue. Also, FindCUDA is departed since CMake 3.10!
Have not tested this in other machines and new to using CUDA, so maybe this might be a wrong approach to this problem...
references:
https://cmake.org/cmake/help/latest/module/FindCUDA.html
https://cmake.org/cmake/help/latest/module/FindCUDAToolkit.html