Fixed a crash due to inconsistent undistortion #1698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When distortion coefficients are really small but not zero, IsUndistorted() may return true, but undistorted image size may still be different from the original image size. In this situation the mismatch between the image size in the model and the actual image size causes the patch match stereo step to crash. This change skips camera undistortion when the coefficients are very small, which makes it consistent with image undistortion and fixes the crash.
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When distortion coefficients are really small but not zero, IsUndistorted() may return true, but undistorted image size may still be different from the original image size. In this situation the mismatch between the image size in the model and the actual image size causes the patch match stereo step to crash. This change skips camera undistortion when the coefficients are very small, which makes it consistent with image undistortion and fixes the crash.